Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum swift-nio version to use async/await FileIO APIs. #414

Merged

Conversation

sidepelican
Copy link
Contributor

2.0.0-beta.2 uses async/await FileIO APIs in NIO.

Package.swift points to 2.62.0 as the minimum version, but this API was introduced in 2.63.0.
INFO: https://github.com/apple/swift-nio/releases/tag/2.63.0

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (e78cde7) to head (cc29978).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   84.86%   83.89%   -0.98%     
==========================================
  Files          98      100       +2     
  Lines        5320     4135    -1185     
==========================================
- Hits         4515     3469    -1046     
+ Misses        805      666     -139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler
Copy link
Member

Thank you

@adam-fowler adam-fowler merged commit 36151e4 into hummingbird-project:main Apr 7, 2024
6 of 7 checks passed
@sidepelican sidepelican deleted the fix_incorrct_nio_dep branch April 7, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants