Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HBApplication.start() to throw errors #73

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

adam-fowler
Copy link
Member

For some reason I had it ignoring errors. This has been rectified

@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #73 (5583f0c) into main (26fc603) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files          52       52           
  Lines        2500     2501    +1     
=======================================
+ Hits         2071     2072    +1     
  Misses        429      429           
Impacted Files Coverage Δ
Sources/Hummingbird/Application.swift 92.72% <100.00%> (ø)
Sources/HummingbirdXCT/Application+XCT.swift 100.00% <100.00%> (ø)
Sources/HummingbirdXCT/HBXCTLive.swift 90.00% <100.00%> (ø)
...Hummingbird/Server/Application+HTTPResponder.swift 100.00% <0.00%> (ø)
Sources/Hummingbird/Server/Request.swift 94.28% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcb6f3...5583f0c. Read the comment docs.

@adam-fowler adam-fowler merged commit 8cee671 into main Apr 26, 2021
@adam-fowler adam-fowler deleted the throwing-start branch April 26, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant