Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delta issues for select tool and clear action #71

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

hunkim98
Copy link
Owner

@hunkim98 hunkim98 commented Sep 27, 2023

🚀 [Related Issue: #70]

Preview


Changes

Allow select tool to emit delta in DataChangeHandler

  • [🎨Component] Add logic for emitting delta in DataChangeHandler

    • Previously, there was not delta emitted from select tool actions (extending, moving)
    • Now, the modified pixels delta is emitted in the DataChangeHandler
  • [📒Docs] Add tools in the DataChangeHandler storybook component

    • To allow testing of delta with other tools, I have added a <select> for choosing the desired tool

Allow clear() to emit delta information in DataChangeHandler

  • [🎨Component] Add logic in clear callback to emit delta data

    • The clear callback did not emit any delta information
    • Since clear erases all data in all layers, I emitted the data change event for every layer, allowing users to notice that all layers are being cleared

Notes


Next Up?

@hunkim98 hunkim98 self-assigned this Sep 27, 2023
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-27 07:59 UTC

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
15.2% 15.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@hunkim98 hunkim98 merged commit 5da82ec into main Sep 27, 2023
3 of 4 checks passed
@hunkim98 hunkim98 deleted the fix/delta branch September 27, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants