forked from alanwalk/markdown-toc
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orderedlist option not working as expected when disable #20
Comments
could you add an expected and actual result of the settings? |
@huntertran sure, please see updated |
mwhebert
pushed a commit
to mwhebert/markdown-toc
that referenced
this issue
Feb 14, 2020
…n if orderedlist was false
merged |
wonderful !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thanks a lot for this useful plugin.
<!-- TOC depthfrom:2 orderedlist:true -->
it will work as expected; will add numbering both on headers as well as in TOC list.
<!-- TOC depthfrom:2 orderedlist:false -->
But when we disable, it will remove the numbering from TOC but not from actual headers. So, the TOC links will not work (links in TOC without number and Actual header link with number)
Any fix ?
Generated TOC
Expected:
when we update
orderedlist:false
, it should be without numbers everywhereActual :
See, numbering removed from TOC and links but not actually from Headers (means a broken link too)
Thanks in advance.
The text was updated successfully, but these errors were encountered: