Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orderedlist option not working as expected when disable #20

Closed
iamgini opened this issue Dec 12, 2019 · 4 comments
Closed

orderedlist option not working as expected when disable #20

iamgini opened this issue Dec 12, 2019 · 4 comments

Comments

@iamgini
Copy link

iamgini commented Dec 12, 2019

First of all, thanks a lot for this useful plugin.

<!-- TOC depthfrom:2 orderedlist:true -->
it will work as expected; will add numbering both on headers as well as in TOC list.

<!-- TOC depthfrom:2 orderedlist:false -->
But when we disable, it will remove the numbering from TOC but not from actual headers. So, the TOC links will not work (links in TOC without number and Actual header link with number)

Any fix ?

Generated TOC

<!-- TOC depthfrom:1 orderedlist:true -->

- [1. Certified Kubernetes Administrator (CKA)](#1-certified-kubernetes-administrator-cka)
  - [1.1. Disclaimer](#11-disclaimer)
  - [1.2. References](#12-references)
- [2. Core Concepts](#2-core-concepts)
  - [2.1. What is ETCD](#21-what-is-etcd)
    - [2.1.1. etcd in k8s](#211-etcd-in-k8s)
  - [2.2. kube-api server](#22-kube-api-server)
  - [2.3. kube controller manager](#23-kube-controller-manager)
    - [2.3.1. Node Controller](#231-node-controller)
    - [2.3.2. Replication Controller](#232-replication-controller)
      - [2.3.2.1. Load balancing and Scaling](#2321-load-balancing-and-scaling)

Expected:
when we update orderedlist:false, it should be without numbers everywhere

<!-- TOC depthfrom:1 orderedlist:false -->

- [Certified Kubernetes Administrator (CKA)](#certified-kubernetes-administrator-cka)
  - [Disclaimer](#disclaimer)
  - [References](#references)
- [Core Concepts](#core-concepts)
  - [What is ETCD](#what-is-etcd)
    - [etcd in k8s](#etcd-in-k8s)
  - [kube-api server](#kube-api-server)
  - [kube controller manager](#kube-controller-manager)
    - [Node Controller](#node-controller)
    - [Replication Controller](#replication-controller)
      - [Load balancing and Scaling](#load-balancing-and-scaling)

.
.
.
.
<!-- /TOC -->


# Core Concepts

## What is ETCD
Distributed reliable key-value store that is simple, secure and fast.

*Learn how to install etcd : https://computingforgeeks.com/how-to-install-etcd-on-rhel-centos-8/*
- etcd will start a service and listen on port 2379
- etcdctl 
    ./etcdctl set key1 value1

### etcd in k8s
- if you install k8s manually, etcd has to install manually
- if k8s installation is by using kubeadm, then kubeadm will install and configure etcd

- etcd will be running under kube-system namespace

Actual :
See, numbering removed from TOC and links but not actually from Headers (means a broken link too)

<!-- TOC depthfrom:1 orderedlist:false -->

- [Certified Kubernetes Administrator (CKA)](#certified-kubernetes-administrator-cka)
  - [Disclaimer](#disclaimer)
  - [References](#references)
- [Core Concepts](#core-concepts)
  - [What is ETCD](#what-is-etcd)
    - [etcd in k8s](#etcd-in-k8s)
  - [kube-api server](#kube-api-server)
  - [kube controller manager](#kube-controller-manager)
    - [Node Controller](#node-controller)
    - [Replication Controller](#replication-controller)
      - [Load balancing and Scaling](#load-balancing-and-scaling)

.
.
.
.
<!-- /TOC -->


# 2. Core Concepts

## 2.1. What is ETCD
Distributed reliable key-value store that is simple, secure and fast.

*Learn how to install etcd : https://computingforgeeks.com/how-to-install-etcd-on-rhel-centos-8/*
- etcd will start a service and listen on port 2379
- etcdctl 
    ./etcdctl set key1 value1

### 2.1.1. etcd in k8s
- if you install k8s manually, etcd has to install manually
- if k8s installation is by using kubeadm, then kubeadm will install and configure etcd

- etcd will be running under kube-system namespace

Thanks in advance.

@huntertran
Copy link
Owner

could you add an expected and actual result of the settings?

@iamgini
Copy link
Author

iamgini commented Dec 17, 2019

@huntertran sure, please see updated

mwhebert pushed a commit to mwhebert/markdown-toc that referenced this issue Feb 14, 2020
@huntertran
Copy link
Owner

merged

@iamgini
Copy link
Author

iamgini commented Feb 18, 2020

wonderful !!
its working now..
thanks @huntertran .... (y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants