Skip to content

Commit 12239e3

Browse files
committed
Require instance based on JsonApiRequest in controller actions
1 parent ddd2e26 commit 12239e3

File tree

1 file changed

+22
-23
lines changed

1 file changed

+22
-23
lines changed

src/Http/Controllers/JsonApiController.php

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
use Illuminate\Database\Eloquent\ModelNotFoundException;
1818
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
1919
use Illuminate\Foundation\Validation\ValidatesRequests;
20-
use Illuminate\Http\Request;
2120
use Illuminate\Http\Response;
2221
use Illuminate\Routing\Controller;
2322
use Illuminate\Validation\ValidationException;
@@ -55,12 +54,12 @@ public function __construct()
5554
/**
5655
* Return a listing of the resource.
5756
*
58-
* @param Request $request
59-
* @param \Illuminate\Database\Eloquent\Builder|null $query Custom resource query
57+
* @param \Huntie\JsonApi\Http\Requests\JsonApiRequest $request
58+
* @param \Illuminate\Database\Eloquent\Builder|null $query Custom resource query
6059
*
6160
* @return JsonApiResponse
6261
*/
63-
public function indexAction(Request $request, $query = null)
62+
public function indexAction($request, $query = null)
6463
{
6564
$records = $query ?: $this->model->newQuery();
6665
$params = $this->getRequestParameters($request);
@@ -84,11 +83,11 @@ public function indexAction(Request $request, $query = null)
8483
/**
8584
* Store a new record.
8685
*
87-
* @param Request $request
86+
* @param \Huntie\JsonApi\Http\Requests\JsonApiRequest $request
8887
*
8988
* @return JsonApiResponse
9089
*/
91-
public function storeAction(Request $request)
90+
public function storeAction($request)
9291
{
9392
$record = $this->model->create((array) $request->input('data.attributes'));
9493

@@ -102,12 +101,12 @@ public function storeAction(Request $request)
102101
/**
103102
* Return a specified record.
104103
*
105-
* @param Request $request
106-
* @param Model|mixed $record
104+
* @param \Huntie\JsonApi\Http\Requests\JsonApiRequest $request
105+
* @param Model|mixed $record
107106
*
108107
* @return JsonApiResponse
109108
*/
110-
public function showAction(Request $request, $record)
109+
public function showAction($request, $record)
111110
{
112111
$record = $this->findModelInstance($record);
113112
$params = $this->getRequestParameters($request);
@@ -119,12 +118,12 @@ public function showAction(Request $request, $record)
119118
/**
120119
* Update a specified record.
121120
*
122-
* @param Request $request
123-
* @param Model|mixed $record
121+
* @param \Huntie\JsonApi\Http\Requests\JsonApiRequest $request
122+
* @param Model|mixed $record
124123
*
125124
* @return JsonApiResponse
126125
*/
127-
public function updateAction(Request $request, $record)
126+
public function updateAction($request, $record)
128127
{
129128
$record = $this->findModelInstance($record);
130129
$record->fill((array) $request->input('data.attributes'));
@@ -140,12 +139,12 @@ public function updateAction(Request $request, $record)
140139
/**
141140
* Destroy a specified record.
142141
*
143-
* @param Request $request
144-
* @param Model|mixed $record
142+
* @param \Huntie\JsonApi\Http\Requests\JsonApiRequest $request
143+
* @param Model|mixed $record
145144
*
146145
* @return JsonApiResponse
147146
*/
148-
public function destroyAction(Request $request, $record)
147+
public function destroyAction($request, $record)
149148
{
150149
$record = $this->findModelInstance($record);
151150
$record->delete();
@@ -156,13 +155,13 @@ public function destroyAction(Request $request, $record)
156155
/**
157156
* Return a specified record relationship.
158157
*
159-
* @param Request $request
160-
* @param Model|mixed $record
161-
* @param string $relation
158+
* @param \Huntie\JsonApi\Http\Requests\JsonApiRequest $request
159+
* @param Model|mixed $record
160+
* @param string $relation
162161
*
163162
* @return JsonApiResponse
164163
*/
165-
public function showRelationshipAction(Request $request, $record, $relation)
164+
public function showRelationshipAction($request, $record, $relation)
166165
{
167166
$record = $this->findModelInstance($record);
168167

@@ -174,15 +173,15 @@ public function showRelationshipAction(Request $request, $record, $relation)
174173
*
175174
* http://jsonapi.org/format/#crud-updating-relationships
176175
*
177-
* @param Request $request
178-
* @param Model|mixed $record
179-
* @param string $relation
176+
* @param \Huntie\JsonApi\Http\Requests\JsonApiRequest $request
177+
* @param Model|mixed $record
178+
* @param string $relation
180179
*
181180
* @throws \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
182181
*
183182
* @return JsonApiResponse
184183
*/
185-
public function updateRelationshipAction(Request $request, $record, $relation)
184+
public function updateRelationshipAction($request, $record, $relation)
186185
{
187186
$record = $this->findModelInstance($record);
188187
$relationType = $this->getRelationType($relation);

0 commit comments

Comments
 (0)