feat: add support for self-hosted fonts #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on the work done by @visualfanatic fonts can now be hosted outside of the `/static` folder and will be copied across by the plugin. From my recollection this is what is suggested in the Gatsby docs. Updated README. Included the Gatsby reporter to throw a panic if file copy to `/public` fails.
hupe1980
requested changes
Aug 14, 2022
hupe1980
requested changes
Sep 9, 2022
- also delete pathPrefix from `publicFolder`
|
Nice! Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per draft PR #10 basic support of self-hosted fonts based on the work of @visualfanatic & @damianstasik
Made some changes to allow for custom font dir.
Added e2e tests.
@hupe1980 Could you please give feedback?