Feature request: Callback when presented and dismissed

[pjcau]

Is your feature request related to a problem? Please describe.
I should have a callback when popup is presented and dismissed, to do actions after presented or dismissed popup.

Describe the solution you'd like
I should have a callback when popup is presented and dismissed.

Describe alternatives you've considered
Maybe it's possible to add a delegate with to methods when finishing the animation for presenting and same when dismissing.

Additional context
nothing

[huri000]

Hi @pjcau,
Sure, could you please edit the issue as a Feature-Request according to the project guidelines and explain exactly your requirements? Then I could review them and decide how to implement a solution.

[pjcau]

@huri000 tell me it's all right. If press edit on post, I can edit only the title not the labels.

J

[huri000]

Great. I'll figure something out and keep you posted (next few days).

[Banck]

@huri000 Hello!
I just wanted to open the same "issue". Could you please add completion block in SwiftEntryKit.dismiss() , because:
I present the new controller when some button was pressing in alert. I have this code:

alertView.okButtonDidTap = {
SwiftEntryKit.dismiss()
okAction?()
}

and in "okAction" I'm presenting the new controller. But the alert is flashing sometimes. If add some delay like 1 second (to be sure, that alert was closed) everything is fine

Thanks

[pjcau]

I thinking, but there are other way to dismiss like drag o tap outside. I should general solution. J Inviato da iPhone

…

Il giorno 14 giu 2018, alle ore 17:47, Banck ***@***.***> ha scritto: @huri000 Hello! I just wanted to open the same "issue". Could you please add completion block in SwiftEntryKit.dismiss() , because: I present the new controller when some button was pressing in alert. I have this code: alertView.okButtonDidTap = { SwiftEntryKit.dismiss() okAction?() } and in "okAction" I'm presenting the new controller. But the alert is flashing sometimes. If add some delay like 1 second (to be sure, that alert was closed) everything is fine Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[pjcau]

I tried your solution but infact works only the user taps the button, not drag or tap outside the message to dismiss. Maybe it's not the good solution for me and this feature.

J

[Banck]

Seems you didn't get me.
I meant, that I need a clouser "completed" in method SwiftEntryKit.dismiss().
I didn't give you any solution, just asked @huri000 to make a closure in SwiftEntryKit.dismiss() too. :-)

[pjcau]

OK, Now it's clear. thank @Banck @huri000

[huri000]

After thinking about it, I'm goings to add another construct to EKAttributes that contains the entry life-cycle callbacks. It's going to look something like:

    public struct LifecycleActions {
        
        public typealias Action = () -> Void

        /** Executed before the entry appears - before the animation starts.
         Might not get called in case another entry with a higher display priority is displayed.
         */
        public var willAppear: Action?
        
        /** Executed after the animation ends.
         Might not get called in case another entry with a higher display priority is displayed.
         */
        public var didAppear: Action?

        /** Executed before the entry disappears (Before the animation starts) */
        public var willDisappear: Action?
        
        /** Executed after the entry disappears (After the animation ends) */
        public var didDisappear: Action?
        
        public init(willAppear: Action? = nil, didAppear: Action? = nil, willDisappear: Action? = nil, didDisappear: Action? = nil) {
            self.willAppear = willAppear
            self.didAppear = didAppear
            self.willDisappear = willDisappear
            self.didDisappear = didDisappear
        }
    }

In addition:

• SwiftEntryKit.dismiss() will have a completion handler
• EKAttributes.PopBehavior will have a completion handler as well.

Let me know your thoughts.
Thanks!

[pjcau]

@huri000 I think that’s OK.

J

[huri000]

Check out 0.4.2

• Lifecycle section in README.md
• Dismissing an Entry in README.md.

I'm a little conflicted about an additional event for pop. It seems overdone to me but I'm still considering it. Let me know if you think otherwise.

I consider the issue resolved. 🎉

[kyrylhorbushko]

thanks for this! especially if u working with SwiftUI and dealing with something like this -isPresented: Binding<Bool>