Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close-button position #244

Merged
merged 6 commits into from
Aug 5, 2016
Merged

Fix close-button position #244

merged 6 commits into from
Aug 5, 2016

Conversation

danicatalan
Copy link
Contributor

@danicatalan danicatalan commented Aug 3, 2016 •
edited by txau
Loading

Fixes issue #27 & #238

PR check list:

  • Client test
  • Server test
  • End-to-end test
  • Pass code linter to client and server
  • Database views added ?

QA check list:

  • Smoke test the functionality described in the issue
  • Smoke test potential collaterals
  • UI responsiveness
  • Tested in a browser other than chrome
  • Code review ?

NOTE: Make sure the build passes.

@txau txau merged commit a26d708 into development Aug 5, 2016
@txau txau deleted the date-picker branch August 5, 2016 12:40
@konzz konzz mentioned this pull request Aug 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danicatalan @txau @konzz