Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French locale #7

Merged
merged 1 commit into from
Sep 7, 2016
Merged

French locale #7

merged 1 commit into from
Sep 7, 2016

Conversation

paulcmal
Copy link
Contributor

@paulcmal paulcmal commented Sep 7, 2016 •
edited by hustcc
Loading

#19 fr.

Hi,

I added French translation strings.

Have a nice day!

@hustcc hustcc merged commit 694c389 into hustcc:master Sep 7, 2016
@hustcc
Copy link
Owner

hustcc commented Sep 7, 2016

Add some locale testcase will be perfect ^_^~

@paulcmal
Copy link
Contributor Author

paulcmal commented Sep 7, 2016

Sure thing. Should I create a tests/locale/ folder in which I just put a frTest.js file ?

Or do you want me to put everything in the current test.js?

@paulcmal
Copy link
Contributor Author

paulcmal commented Sep 7, 2016

#8 fixes translation and brings the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcmal @hustcc