Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server.js #474

Merged
merged 1 commit into from
Dec 10, 2016
Merged

Update server.js #474

merged 1 commit into from
Dec 10, 2016

Conversation

vikramdurai
Copy link
Contributor

@vikramdurai vikramdurai commented Dec 9, 2016

A small change to make it that it outputs "localhost:{port}" or "127.0.0.1:{port}"

   

@vikramdurai
Copy link
Contributor Author

:shipit:

4 similar comments
@CoderJoeW
Copy link
Contributor

:shipit:

@CoderJoeW
Copy link
Contributor

:shipit:

@CoderJoeW
Copy link
Contributor

:shipit:

@igorantun
Copy link
Collaborator

:shipit:

@igorantun igorantun merged commit 3a5f5a2 into owenashurst:master Dec 10, 2016
@vikramdurai vikramdurai deleted the patch-1 branch December 10, 2016 11:53
@abalabahaha
Copy link
Collaborator

This is really misleading and shouldn't have been merged at all. If an IP address is passed to http.listen(), node will listen on that IP, not localhost. Otherwise, node would listen on 0.0.0.0 (or :: on IPv6), not 127.0.0.1.

abalabahaha added a commit that referenced this pull request Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants