-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: separate model and deployment for OpenAIEmbeddings #3076
fix: separate model and deployment for OpenAIEmbeddings #3076
Conversation
Remove deprecated document_model_name and query_model_name
# TODO: deprecate these two in favor of model | ||
# https://community.openai.com/t/api-update-engines-models/18597 | ||
# https://github.com/openai/openai-python/issues/132 | ||
document_model_name: str = "text-embedding-ada-002" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hwchase17 technically breaking change, how do we feel about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Thanks for the update! This still results in I am assuming there is nothing we can do about that and it is on Azures end ( besides |
…#3076) Separated the deployment from model to support Azure OpenAI Embeddings properly. Also removed the deprecated document_model_name and query_model_name attributes.
Separated the deployment from model to support Azure OpenAI Embeddings properly.
Also removed the deprecated document_model_name and query_model_name attributes.