core: add mixChannels() method to Mat #746
Conversation
| cSrcMats := C.struct_Mats{ | ||
| mats: (*C.Mat)(&cSrcArray[0]), | ||
| length: C.int(len(src)), | ||
| } | ||
|
|
||
| cDstArray := make([]C.Mat, len(dst)) | ||
| for i, r := range dst { | ||
| cDstArray[i] = r.p | ||
| } | ||
| cDstMats := C.struct_Mats{ | ||
| mats: (*C.Mat)(&cDstArray[0]), | ||
| length: C.int(len(dst)), | ||
| } | ||
|
|
||
| cFromToArray := make([]C.int, len(fromTo)) | ||
| for i, ft := range fromTo { | ||
| cFromToArray[i] = C.int(ft) | ||
| } | ||
|
|
||
| cFromToIntVector := C.IntVector{ | ||
| val: (*C.int)(&cFromToArray[0]), | ||
| length: C.int(len(fromTo)), | ||
| } | ||
|
|
There was a problem hiding this comment.
I added locally, accordingly all the defers close mats and close intvector:
cSrcMats := C.struct_Mats{
mats: (*C.Mat)(&cSrcArray[0]),
length: C.int(len(src)),
}
defer C.Mats_Close(cSrcMats)
cDstArray := make([]C.Mat, len(dst))
for i, r := range dst {
cDstArray[i] = r.p
}
cDstMats := C.struct_Mats{
mats: (*C.Mat)(&cDstArray[0]),
length: C.int(len(dst)),
}
defer C.Mats_Close(cDstMats)
cFromToArray := make([]C.int, len(fromTo))
for i, ft := range fromTo {
cFromToArray[i] = C.int(ft)
}
cFromToIntVector := C.IntVector{
val: (*C.int)(&cFromToArray[0]),
length: C.int(len(fromTo)),
}
defer C.IntVector_Close(cFromToIntVector)But they are failing locally, for instance:
goroutine 0 [idle]:
runtime: unknown pc 0x7f1645a1c438
If I remove the defer the test passes, but the build fails because of TestMatProfile. Any clue what I am doing wrong?
There was a problem hiding this comment.
Well, at first glance you do not need any of the defers there. For example defer C.Mats_Close(cDstMats) would close the dst value, which is not what you would want right after returning.
I think perhaps the test itself it the issue. See comment below.
| @@ -2015,6 +2015,44 @@ func TestMatMinMaxIdx(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestMixChannels(t *testing.T) { | |||
| bgra := NewMatWithSizeFromScalar(NewScalar(255, 0, 0, 255), 10, 10, MatTypeCV8UC4) | |||
There was a problem hiding this comment.
You need a defer bgra.Close() here.
| @@ -2015,6 +2015,44 @@ func TestMatMinMaxIdx(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestMixChannels(t *testing.T) { | |||
| bgra := NewMatWithSizeFromScalar(NewScalar(255, 0, 0, 255), 10, 10, MatTypeCV8UC4) | |||
| bgr := NewMatWithSize(bgra.Rows(), bgra.Cols(), MatTypeCV8UC3) | |||
There was a problem hiding this comment.
You need a defer bgr.Close() here.
| func TestMixChannels(t *testing.T) { | ||
| bgra := NewMatWithSizeFromScalar(NewScalar(255, 0, 0, 255), 10, 10, MatTypeCV8UC4) | ||
| bgr := NewMatWithSize(bgra.Rows(), bgra.Cols(), MatTypeCV8UC3) | ||
| alpha := NewMatWithSize(bgra.Rows(), bgra.Cols(), MatTypeCV8UC1) |
There was a problem hiding this comment.
You need a defer alpha.Close() here.
|
Also can you please rebase against the |
toffentoffen
force-pushed
the
arrays-opt-mixchannels
branch
from
3ee68a0
to
b241100
Compare
|
I don't know what I was thinking, after your explanation and after running the test locally with |
|
Added hacktoberfest to repo itself. |
|
Now squash/merging. Thanks for another useful contribution @toffentoffen it is appreciated! |
Add MixChannels method for enhancement request #745