-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove python dependency for a build script #173
Conversation
The drawback of replacing python script by bash script is it will be working only on Linux computer (or MSYS2/MINGW64) I will really prefer a more universal way to do it by replacing those python script by C portable code built as native executable which can be executed on any computer. |
The script should work with WSL 2 (i need to test it) and it does work in macos. For cross-portability, I can provide Go, not C. |
I will prefer to avoid Go (which will add even more complexity/dependencies) the aim is to have something simple and multi platform at least to build the firmware. |
Nice idea, I had a quite similar approach in this branch here: https://github.com/Baldanos/hydrafw/tree/nopython Replacing Python with Go or something else wouldn't make any improvement. However, as long as a fix is available and works on Windows and Linux, I think we should go for it |
@seuros Does this PR is ready for merge or do you want to check/finish something ? |
I'm using this code currently in Linux and Macos. Should we provide a powershell alternative? |
I prefer to avoid powershell specific windows stuff especially we can build it with MSYS2/MINGW64 like it is described in the https://github.com/hydrabus/hydrafw/wiki/how-to-build-flash-and-use-hydrafw-on-windows |
Thanks for your contribution |
I will other PR later.
part of #132