Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove python dependency for a build script #173

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

seuros
Copy link
Contributor

@seuros seuros commented May 2, 2024

I will other PR later.

part of #132

@bvernoux
Copy link
Member

bvernoux commented May 7, 2024

The drawback of replacing python script by bash script is it will be working only on Linux computer (or MSYS2/MINGW64) I will really prefer a more universal way to do it by replacing those python script by C portable code built as native executable which can be executed on any computer.
To be discussed with @Baldanos

@seuros
Copy link
Contributor Author

seuros commented May 7, 2024

The script should work with WSL 2 (i need to test it) and it does work in macos.
We can also add Powershell if needed if the aim is to remove Python.

For cross-portability, I can provide Go, not C.

@bvernoux
Copy link
Member

bvernoux commented May 7, 2024

The script should work with WSL 2 (i need to test it) and it does work in macos. We can also add Powershell if needed if the aim is to remove Python.

For cross-portability, I can provide Go, not C.

I will prefer to avoid Go (which will add even more complexity/dependencies) the aim is to have something simple and multi platform at least to build the firmware.
At start we can live with bash/shell solution (it is always better than to have Python dependency for 2 scripts) to be discussed with @Baldanos

@Baldanos
Copy link
Collaborator

Nice idea, I had a quite similar approach in this branch here: https://github.com/Baldanos/hydrafw/tree/nopython

Replacing Python with Go or something else wouldn't make any improvement. However, as long as a fix is available and works on Windows and Linux, I think we should go for it

@bvernoux
Copy link
Member

bvernoux commented Jun 11, 2024

@seuros Does this PR is ready for merge or do you want to check/finish something ?

@seuros
Copy link
Contributor Author

seuros commented Jun 11, 2024

I'm using this code currently in Linux and Macos.

Should we provide a powershell alternative?

@bvernoux
Copy link
Member

I prefer to avoid powershell specific windows stuff especially we can build it with MSYS2/MINGW64 like it is described in the https://github.com/hydrabus/hydrafw/wiki/how-to-build-flash-and-use-hydrafw-on-windows

@bvernoux bvernoux merged commit 7161987 into hydrabus:master Jun 11, 2024
1 check passed
@bvernoux
Copy link
Member

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants