Make other executable extension selectable in game-details filepicker #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrlkx
reviewed
Jun 23, 2024
| @@ -141,7 +141,7 @@ export function GameDetailsContextProvider({ | |||
| filters: [ | |||
| { | |||
| name: "Game executable", | |||
| extensions: ["exe"], | |||
| extensions: ["exe", "bash", "sh", "bat"], //TODO: check if empty extension can be added, so it's possible to select linux binaries without extinsion. Add if can be added. | |||
There was a problem hiding this comment.
AFAIK empty is not a valid option but we could have something like this.
{ name: 'All Files', extensions: ['*'] }There was a problem hiding this comment.
It would be so wonderful if it was possible to filter files by their execution permissions. I think this solution is good enough though
|
There is one big problem in selecting other files. Hydra won't be able to get the executable name to observe its process and count the playtime |
|
Would explicitly forbidding running games as background jobs in the documentation be a good solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executables with extensions different from
.execurrently aren't selectable in the file-picker. This PR adds following extensions to file-picker filter:bat,shandbash.