Skip to content
This repository has been archived by the owner on Aug 10, 2019. It is now read-only.

Enables g++ compilation #23

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Enables g++ compilation #23

merged 3 commits into from
Sep 18, 2018

Conversation

vsreekanti
Copy link
Member

@vsreekanti vsreekanti commented Sep 18, 2018

Fixes #15, #20.

  • Enables support for compilation with GNU g++.
  • g++ compilation transitively enables compilation on Fedora.
  • Also changes scripts/install-dependencies.sh to detect Linux distribution base and react appropriately.

For some reason, make test fails with a seg fault when compiling with g++, but the KVS processes all still are able to start, and the simple test succeeds. It just a bug with the unit tests.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   62.72%   62.72%           
=======================================
  Files          50       50           
  Lines        1438     1438           
=======================================
  Hits          902      902           
  Misses        536      536
Impacted Files Coverage Δ
kvs/src/hash_ring/hash_ring.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff703d...d4b51a4. Read the comment docs.

Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@810367a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   62.72%           
=========================================
  Files             ?       50           
  Lines             ?     1438           
  Branches          ?        0           
=========================================
  Hits              ?      902           
  Misses            ?      536           
  Partials          ?        0
Impacted Files Coverage Δ
kvs/src/hash_ring/hash_ring.cpp 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810367a...42c334b. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   62.79%   62.79%           
=======================================
  Files          50       50           
  Lines        1454     1454           
=======================================
  Hits          913      913           
  Misses        541      541
Impacted Files Coverage Δ
kvs/src/hash_ring/hash_ring.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810367a...42c334b. Read the comment docs.

@vsreekanti vsreekanti merged commit 1f3e7dd into hydro-project:master Sep 18, 2018
@vsreekanti vsreekanti deleted the gnu-compile branch September 18, 2018 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants