Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feature/ght #1308

Merged
merged 115 commits into from
Oct 22, 2024
Merged

feat: Feature/ght #1308

merged 115 commits into from
Oct 22, 2024

Conversation

jhellerstein
Copy link
Contributor

WIP on Generalized Hash Trie

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 24, 2024 •
edited
Loading

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 739b29f
Status:⚡️  Build in progress...

View logs

@rohitkulshreshtha rohitkulshreshtha mentioned this pull request Jun 27, 2024
Closed
@jhellerstein @MingweiSamuel
initial GHT implementation. depends on #1245 and #1242
5dc3f61
@jhellerstein @MingweiSamuel
mostly working, some trouble with contains on references
57aab24
@jhellerstein @MingweiSamuel
passing tests
e639095
@jhellerstein @MingweiSamuel
syncing to github
1afb0b7
@jhellerstein @MingweiSamuel
working to_hash_trie and get()
2de3dda
@jhellerstein @MingweiSamuel
move GHT to lattices, complete get() and iter()
b0f8391
@jhellerstein @MingweiSamuel
WIP: Len trait working, Merge trait in progress
d631466
@jhellerstein @MingweiSamuel
Merge now working
8e2c3c8
@jhellerstein @MingweiSamuel
WIP: PartialOrd and Merge compiling, need to be tested
b3398a9
@jhellerstein @MingweiSamuel
WIP: added LatticeOrd, Eq, IsBot, IsTop traits
5e3ddc3
@jhellerstein @MingweiSamuel
WIP: lattice tests passing
a813cc9
@jhellerstein @MingweiSamuel
simplify ergonomics, test in hydroflow
a074bc6
@jhellerstein @MingweiSamuel
WIP: try to get bimorphisms and GHT to coexist
b0fea7a
@jhellerstein @MingweiSamuel
create a metadata trait for the whole GHT, old trait is now GHTNode
7d8ef49
@jhellerstein @MingweiSamuel
Ght wrapper now supports most lattice traits.
1d1c3b5
@jhellerstein @MingweiSamuel
WIP: fix keyed bimorphism
4948f50
@jhellerstein @MingweiSamuel
WIP: bimorphisms now working on GeneralizedHashTrieNode
7fb1140
MingweiSamuel
MingweiSamuel reviewed Jun 27, 2024
View reviewed changes
variadics/src/lib.rs Outdated Show resolved Hide resolved
@jhellerstein
clean up GhtType macros
31ec8e0
@jhellerstein
clean up warnings
d423d77
@jhellerstein
rename variadics/hash_set.rs to variadic_sets.rs and move VariadicCol…
b4cb439 
…umnarSet
@jhellerstein
move TupleSet to variadics/variadic_set.rs
43496b9
@jhellerstein
move GhtTakeLeaf to ght_lazy.rs
2e43f5a
@jhellerstein
cleanup
d1309a0
@jhellerstein
cleanup
6a17c47
@jhellerstein
mostly working. variadic_sets.rs tests not quite done
73212b9
@jhellerstein
fix hashing on insrt for VariadicCountedHashSet
4ab5d17
@jhellerstein
clean up variadics, still need to fix lattice tests
41bc04a
@jhellerstein
clean up variadics
7540c69
@jhellerstein
Merge remote-tracking branch 'origin/main' into feature/ght
dd5ed5c
@jhellerstein
fix macros/last ght not working 2024-10-10
943dcdf
@jhellerstein
fix: ColtNode uses merge_node not Merge, tests pass
dea8551
@jhellerstein
clean up variadics
64a100e
@jhellerstein
wip
49ab408
@jhellerstein
WIP
a11eea0
@jhellerstein
storage WIP
c739d05
@jhellerstein
ColtNode complete
a131e85
@jhellerstein
remove sealed from ght
c973b2d
@jhellerstein
wip: ght review
27a8be3
@jhellerstein
wip: initial review of ght.rs
ba784a1
@jhellerstein
clean up ght files
5350674
@jhellerstein
clean out dead tests
6680004
@jhellerstein
reviewed. candidate for merge and push to main.
5c6d52f
@jhellerstein
pass format checks
d8a6fc3
@jhellerstein
fix cargo doc error
cd51093
@jhellerstein
revert code to remove bug in partial_cmp for GhtInner
72f81ca
@jhellerstein
fix: complaints from clippy
739b29f
@jhellerstein jhellerstein merged commit 3750af5 into main Oct 22, 2024
18 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MingweiSamuel MingweiSamuel MingweiSamuel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhellerstein @MingweiSamuel @agiron123