Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hydroflow_plus_test): reorganize examples, one per file, add local compute_pi example #1333

Merged
merged 4 commits into from
Jul 10, 2024
Merged

refactor(hydroflow_plus_test): reorganize examples, one per file, add local compute_pi example #1333

merged 4 commits into from
Jul 10, 2024

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Jul 8, 2024 •
edited
Loading

fix #1306

@MingweiSamuel MingweiSamuel changed the title hydroflow plus example refactoring (wip) refactor(hydroflow_plus_test): reorganize examples into individual files, add local compute_pi example Jul 9, 2024
@MingweiSamuel MingweiSamuel marked this pull request as ready for review July 9, 2024 20:35
davidchuyaya
davidchuyaya approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@davidchuyaya davidchuyaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MingweiSamuel MingweiSamuel changed the title refactor(hydroflow_plus_test): reorganize examples into individual files, add local compute_pi example refactor(hydroflow_plus_test): reorganize examples, one per file, add local compute_pi example Jul 9, 2024
@MingweiSamuel
Copy link
Member Author

Oh still need to move the ones in lib.rs too

@MingweiSamuel MingweiSamuel merged commit bedbb3f into hydro-project:main Jul 10, 2024
13 checks passed
@MingweiSamuel MingweiSamuel deleted the hfp-example branch July 10, 2024 21:28
jhellerstein pushed a commit that referenced this pull request Jul 29, 2024
@MingweiSamuel @jhellerstein
refactor(hydroflow_plus_test): reorganize examples, one per file, add…
5e87bdf 
… local `compute_pi` example (#1333)

fix #1306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidchuyaya davidchuyaya davidchuyaya approved these changes

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a simple benchmarkable Hydroflow+ example, reorganize hydroflow_plus_test
3 participants
@MingweiSamuel @shadaj @davidchuyaya