Add return as a special form
#1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi64
reviewed
Aug 11, 2017
hy/compiler.py
Outdated
| value = None | ||
| ret = Result() | ||
| if len(expr) > 1: | ||
| value = self.compile(expr[1]) |
There was a problem hiding this comment.
Slightly bikeshedding, but here value is switching types which is kinda confusing. Usually in the compiler code, this would just be something like:
compiled_expr = self.compile(expr[1])
ret += compiled_expr
value = compiled_expr.force_expror maybe another name still.
There was a problem hiding this comment.
I just realized that I can get rid of one of the assignments, because ret.force_expr works, so I did that.
Closed
|
@kirbyfan64 How's that? |
refi64
approved these changes
Aug 12, 2017
tuturto
approved these changes
Aug 19, 2017
|
Whoops, I hadn't written the NEWS item or documentation yet. I probably should've done that after the first approval. I'll do it in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #739.
To do: