Fix repr and hy-repr for f-strings
#2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer support Pythons too old to have f-strings.
|
No, I also have some changes to make left over from #1550. |
|
i'll take a stab at #1873 then. I'll get a review for this in after work |
Kodiologist
force-pushed
the
hy-repr-fstring
branch
3 times, most recently
from
9098d74
to
8ef12f5
Compare
Co-authored-by: Peter <appa@gmx.co.uk>
This checks a regression caused by a previous version of a previous commit.
Kodiologist
force-pushed
the
hy-repr-fstring
branch
from
8ef12f5
to
797835b
Compare
allison-casey
approved these changes
May 6, 2021
scauligi
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2033.