Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Coverity (static code analysis) #120

Closed
sowle opened this issue Sep 22, 2019 · 2 comments
Closed

Set up Coverity (static code analysis) #120

sowle opened this issue Sep 22, 2019 · 2 comments
Assignees

Comments

@sowle
Copy link
Collaborator

sowle commented Sep 22, 2019

Set up Coverity and incorporate it in CI scheme.

A note Regarding double try-catch.
They seem to be useless in our case because we're using C++11
In C++11 another exception cannot be thrown if there's already one in-flight, it will trigger std::terminate immediately. What's to do:

  1. Implement custom std::terminate handler to catch and log such issues (at least we will be aware that smth went wrong) -- done
  2. Consider adding to the code standard using noexcept(false) in destructors.
  3. Make all logging routines and mactors excepton-safe.
  4. Make sure all this stuff passes Covetity
  5. Refactor CATCH_* macros
@cryptozoidberg
Copy link
Member

Coverity Scan integration is setup: https://scan.coverity.com/projects/zanoproject
TODO: add automation

@cryptozoidberg
Copy link
Member

First iteration of fixes finished, new iteration planed with #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants