Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AVModeIOS audio setting #409

Merged
merged 4 commits into from
Jan 4, 2022
Merged

New AVModeIOS audio setting #409

merged 4 commits into from
Jan 4, 2022

Conversation

udfalkso
Copy link
Contributor

I had the need to use measurement mode while recording background audio. I thought others may have similar needs. This PR adds a new mode setting for ios.

Thanks for the great lib! Please let me know if I need to adjust this PR in any way.

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@udfalkso
Hello! Thanks for your great contribution!

Could you kindly fix the CI failing?

@hyochan hyochan added 🍗 enhancement New feature or request 📱 iOS Related to iOS labels Jan 3, 2022
@udfalkso
Copy link
Contributor Author

udfalkso commented Jan 3, 2022

How's it look now?

@hyochan
Copy link
Owner

hyochan commented Jan 3, 2022

How's it look now?

Still failing on tsc. It will automatically run on next commit I think.

@udfalkso
Copy link
Contributor Author

udfalkso commented Jan 3, 2022

Sorry I think I got it this time. Thanks

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan added the 🎯 feature New feature label Jan 4, 2022
@hyochan hyochan merged commit 3443e42 into hyochan:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request 🎯 feature New feature 📱 iOS Related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants