Add logo #29
Add logo #29
Conversation
jest.config.js
Outdated
| @@ -9,6 +9,11 @@ module.exports = { | |||
| transform: { | |||
| "^.+\\.(ts|tsx)$": "ts-jest", | |||
| }, | |||
| moduleNameMapper: { | |||
There was a problem hiding this comment.
@dipeshwalia is it the only way to mock png files? should I do that any way?
There was a problem hiding this comment.
Why we need this. even why we need jest.config.js ?, you can use assetsTransformer for jest
Package.json
"jest": {
"moduleNameMapper": {
"\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/src/utils/assetsTransformer.js",
"\\.(css|less)$": "<rootDir>/src/utils/assetsTransformer.js"
}
}
assetsTransformer:
jestjs/jest#2663 (comment)
There was a problem hiding this comment.
Why should me merge jest.config into package.json?
There was a problem hiding this comment.
Because it's mis leading.
React scripts provide us basic jest configuration and not every jest configuration will be entertain by react scripts.
https://create-react-app.dev/docs/running-tests/#configuration
| @@ -13,6 +13,20 @@ exports[`Bootcamp renders as expected 1`] = ` | |||
| <div | |||
| className="MuiToolbar-root MuiToolbar-regular MuiToolbar-gutters" | |||
There was a problem hiding this comment.
I don't see value with snapshot 🌊
There was a problem hiding this comment.
Testing = confidence in app.
Snapshot doesn't bring any.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 97.21% 97.31% +0.10%
==========================================
Files 23 24 +1
Lines 251 261 +10
Branches 8 8
==========================================
+ Hits 244 254 +10
Misses 7 7
Continue to review full report at Codecov.
|
| className?: string | undefined | ||
| } | ||
|
|
||
| const getLogoPath = () => `${process.env.PUBLIC_URL}/static/images/logo.png` |
There was a problem hiding this comment.
You ok with this Boss @dipeshwalia ?
There was a problem hiding this comment.
this is ok for now, but its good to avoid any env on ui.
Later on we can have configuration service to feed those value to Ui.
There was a problem hiding this comment.
I'm gonna add an issue for that
Removed a mock file
Added assetsTransformer.js
Updated jest.config
Updated Bootcamp snapshot