Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read response Message from server on send #21

Closed
wants to merge 1 commit into from
Closed

Read response Message from server on send #21

wants to merge 1 commit into from

Conversation

loffa
Copy link

@loffa loffa commented Oct 26, 2016

According to the remote protocol specification for the sound mixer Behringer X32 here the server creates a response when sending a message.

I tried to read the response and have it as a return parameter of the send function.

@daveyarwood
Copy link
Contributor

I think this PR can be closed because:

  • It's over 3 years old and thus out of date with the current state of master.

  • It makes a breaking change to the signature of client.Send.

  • I think having the client.Send function also receive after sending is not the correct behavior. The behavior @loffa described sounds specific to a particular use case and might be better served in a more general way. Perhaps there could be a separate SendAndReceive method?

@loffa
Copy link
Author

loffa commented Mar 10, 2020

Hey, great idea.

I will create a new PR with a separated function for SendAndReceive instead. Have actually been waiting for some action in this Lib to get my integration with the mixer working.

@loffa loffa closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants