Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull concrete dispatcher logic out of server #33

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Pull concrete dispatcher logic out of server #33

merged 1 commit into from
Dec 2, 2019

Conversation

glynternet
Copy link
Contributor

This allows the use of custom Dispatchers, making the Server more flexible.

Previously, the * handler could be used but this would still mean that the logic of the OscDispatcher would have to be gone through before being routed to the defaultHandler.

@glynternet
Copy link
Contributor Author

@hypebeast is this something that you'd be at all open to considering to merge in? I'd much prefer to do something you're happy with and have it upstreamed than maintain a fork myself!

And thanks for the great work to get us here, too! I use this package a lot and love it!

@hypebeast hypebeast merged commit 2516e30 into hypebeast:master Dec 2, 2019
@hypebeast
Copy link
Owner

Hey glynternet,

Thanks a lot for your PR. It think it makes the interface clearer and easier to understand. I merged your PR.

And sorry, for my late reply. I'll try to have a look at open PRs and the discussions during the next one or two days.

@glynternet glynternet deleted the gh/standard-dispatcher branch December 2, 2019 21:44
@glynternet
Copy link
Contributor Author

Brilliant, thanks 😃

Hope you are well.

@hypebeast
Copy link
Owner

Yes, everything perfect :) Now, I'm trying to catch with all the stuff happening here ;) Super nice to see that this lib is getting some attention :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants