Improved escaping of user-provided values when generating shortcode markup #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for only getting around to replying now. Like you say this does make most sense when values are user provided, but as long as it doesn't cause issues I'm happy to merge this PR. As a matter of formality can you sign our Contributors License Agreement here https://hyperaud.io/cla/ ? Many thanks! |
|
Sure thing. I've just signed the CLA. |
|
This looks good. Many thanks @boonebgorges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thanks for your work on this plugin!
I'd like to use it for a client, but on review, I noticed some issues with the way that user-provided data is being used to generate markup. To protect against XSS and other vulnerabilities, I've reviewed
hyperaudio.phpand put into place some best practices for escaping when building markup.(I realize there's a handful of places where the values are not really user-provided and the escaping might be overkill, but for consistency it's generally recommend in WordPress-world to default to escaping everywhere possible.)