Compatibility with RequireJS

[gregwym]

Hi,

Thanks for this directive, works well. One of the problem i experienced with your setup is the compatibility with RequireJS.

Cuz marked is compatible with AMD standard, when it detect define exists, it will not expost marked into window any more. So the directive will fail to get window.marked.

My work around is manually expose marked into window in the RequireJS bootstrap script.

require(['marked'], function(marked) {
  this.marked = marked;
});

Tho it works well, it's still better to support RequireJS out of the box. Sorry I cannot provide a patch, cuz I'm not sure what's the ideal way of doing this. I will if I find a good solution.

Thanks again for this good lib,
Greg

[Hypercubed]

Since I've never worked with RequireJS I would need some time to look at this. If your solution works and is compatible please submit a PR.

[gregwym]

Ye it works, but it's not part of the lib. It's a work around that manually exposing marked into the window global object.

[Hypercubed]

Do you have an example of any other angular module that support RequireJS "out of the box"?

[Hypercubed]

I tried a few things... as far as I can tell when using requirejs with angularjs you need to ensure the requirements are loaded before you bootstrap your app. I think you are going to have to do exactly what you did.... add marked to the window. I tried using require within my module but I couldn't get the angular app to wait for the require callback.

Then again I don't really know anything about requirejs.

[Hypercubed]

Unless someone can show me a better way I think the solution when using require is manually add marked to the global object as @gregwym pointed out:

require(['marked'], function(marked) {
  this.marked = marked;
});

Closing.