Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested winston import #98

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

wrn14897
Copy link
Contributor

The imports 'winston' in nest logger (

import winston from 'winston';
) that conflicts with the custom auto instrumentation pkg since winston will get initialized before otel winston's patch.

To avoid the issue, we don't want to import the node-logger index file

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 1103b71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperdx/node-opentelemetry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wrn14897 wrn14897 merged commit 517dccf into main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants