-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password requirements to login page #103
Add password requirements to login page #103
Conversation
|
Thanks for fixing the issue. Do you mind sharing the screenshot ? |
|
I think it would be cleaner if we have a list of policies underneath. Ideally policy checks automatically. But for now I think we can just leave it as a normal list. |
Nice, will do. We'll see how I get along with the checking-as-satisfied section, but at the very least a static list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final few nits I'd love to see if we can squeeze in - but things look great otherwise :) like the nice touch of the confirm password label being dynamic as well
Co-authored-by: Mike Shi <t7.mike@gmail.com>
Local version is failing with
Which is a weird one because it's installed and worked previously 🤷 Anyway, no screenshot from this round for that reason but the changes should be in place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaggederest you might need to run your setup with |
closes #90
Would appreciate some feedback on placement and styling - wanted to fit it into the
Label
element but thought it might be better after the form field