Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add path alias to api package #107

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Nov 16, 2023

small dev ex improvement:

Before: import { ... } from '../../../fixtures';
After: import { ... } from '@/fixtures';

after checking out, rebuild api and task-check-alerts containers:

docker compose -f docker-compose.dev.yml up -d --no-deps --build task-check-alerts api

Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: ad6cd93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-shorpo svc-shorpo force-pushed the hdx-152-path-aliases branch 2 times, most recently from 7bcee02 to 2d10b5b Compare November 16, 2023 04:57
Copy link
Contributor

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 🥇

@wrn14897
Copy link
Contributor

small dev ex improvement:

Before: import { ... } from '../../../fixtures'; After: import { ... } from '@/fixtures';

after checking out, rebuild api and task-check-alerts containers:

docker compose -f docker-compose.dev.yml up -d --no-deps --build task-check-alerts api

The alternative is

make dev-build

@kodiakhq kodiakhq bot merged commit 42969f2 into hyperdxio:main Nov 17, 2023
3 checks passed
@svc-shorpo svc-shorpo deleted the hdx-152-path-aliases branch November 18, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants