Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate HyperDX API Key to app properly in dev docker compose #113

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Propagate HyperDX API Key to app properly in dev docker compose #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01c254f
Propagate HyperDX API Key to app properly in dev docker compose
MikeShi42 Nov 19, 2023
f06c3a1
Remove old api key env var
MikeShi42 Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ services:
- 8080:8080
environment:
NEXT_PUBLIC_API_SERVER_URL: 'http://localhost:8000' # need to be localhost (CORS)
NEXT_PUBLIC_HDX_API_KEY: ${HYPERDX_API_KEY}
HYPERDX_API_KEY: ${HYPERDX_API_KEY}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah can we also remove NEXT_PUBLIC_HDX_API_KEY here since its not used ?

NEXT_PUBLIC_HDX_COLLECTOR_URL: 'http://localhost:4318'
NEXT_PUBLIC_HDX_SERVICE_NAME: 'hdx-oss-dev-app'
NODE_ENV: development
Expand Down
Loading