Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time chart group count regression #190

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

MikeShi42
Copy link
Contributor

@MikeShi42 MikeShi42 commented Jan 5, 2024

We were showing the "Only showing top N groups" indicator in line charts extraneously from #184. I've removed the UI since it's been somewhat broken for some while, and patched the group counter logic so it's not completely broken at least.

Copy link

changeset-bot bot commented Jan 5, 2024

⚠️ No Changeset found

Latest commit: 52be529

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MikeShi42 MikeShi42 merged commit 9d24d2d into main Jan 5, 2024
4 checks passed
@MikeShi42 MikeShi42 deleted the mikeshi/fix-time-chart-group-count branch January 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants