-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Persist AppNav between navigations #234
Conversation
|
@@ -645,7 +645,7 @@ export default function SearchPage() { | |||
}, [setResultsMode]); | |||
|
|||
return ( | |||
<div className="LogViewerPage d-flex" style={{ height: '100vh' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing out locally I suspect this is breaking the search table scroll behavior (we're scrolling the page instead of the search results)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
b2929c6
to
87bd46a
Compare
87bd46a
to
bbbaa6b
Compare
made some tweaks to appnav: Screen.Recording.2024-01-13.at.8.47.09.PM.mov
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢🚢🚢🚢🚢
Before
Screen.Recording.2024-01-13.at.1.30.43.PM.mov
After:
Screen.Recording.2024-01-13.at.1.29.36.PM.mov