feat: Persist AppNav between navigations #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
svc-shorpo
changed the title
MikeShi42
reviewed
Jan 14, 2024
| @@ -645,7 +645,7 @@ export default function SearchPage() { | |||
| }, [setResultsMode]); | |||
|
|
|||
| return ( | |||
| <div className="LogViewerPage d-flex" style={{ height: '100vh' }}> | |||
There was a problem hiding this comment.
Testing out locally I suspect this is breaking the search table scroll behavior (we're scrolling the page instead of the search results)
svc-shorpo
force-pushed
the
sr/persistent-layout
branch
from
b2929c6
to
87bd46a
Compare
svc-shorpo
force-pushed
the
sr/persistent-layout
branch
from
87bd46a
to
bbbaa6b
Compare
|
made some tweaks to appnav: Screen.Recording.2024-01-13.at.8.47.09.PM.mov
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Screen.Recording.2024-01-13.at.1.30.43.PM.mov
After:
Screen.Recording.2024-01-13.at.1.29.36.PM.mov