ext dashboard api #267
Merged
ext dashboard api #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wrn14897
reviewed
Jan 22, 2024
| }, | ||
| ); | ||
|
|
||
| router.get('/', async (req, res, next) => { |
There was a problem hiding this comment.
do we need limit and offset for this guy ?
wrn14897
reviewed
Jan 22, 2024
| const dashboards = await Dashboard.find( | ||
| { team: teamId }, | ||
| { _id: 1, name: 1, charts: 1, query: 1 }, | ||
| ).sort({ name: -1 }); |
There was a problem hiding this comment.
we might want to expose sort query to the user (like name or createdAt)
MikeShi42
force-pushed
the
mikeshi/ext-dashboard-api
branch
from
4ee1f09
to
0663701
Compare
wrn14897
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.