Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Mantine@7 #306

Merged
merged 2 commits into from
Feb 25, 2024
Merged

chore: Upgrade to Mantine@7 #306

merged 2 commits into from
Feb 25, 2024

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Feb 11, 2024

really like the fact they moved away from css-in-js haha

Stack/Group spacing => gap
Stack/Group position => justify
Button compact prop => size
Button, Input, etc icon/leftIcon prop => leftSection
sx prop => style
Table thead/tbody/tr/td => <Table.Thead> / <Table.Tbody> / <Table.Tr> / <Table.Td>
Badge - set variant="light" prop

To do:

  • Tables
  • Update all Badge variant to light

more testing won't hurt :D

Copy link

changeset-bot bot commented Feb 11, 2024

⚠️ No Changeset found

Latest commit: 13b1eaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-shorpo svc-shorpo marked this pull request as draft February 11, 2024 19:43
@svc-shorpo svc-shorpo force-pushed the sr/mantine-7 branch 2 times, most recently from f716482 to 618135d Compare February 11, 2024 19:55
@svc-shorpo svc-shorpo marked this pull request as ready for review February 11, 2024 20:00
@svc-shorpo svc-shorpo force-pushed the sr/mantine-7 branch 3 times, most recently from de4977f to 7c695ef Compare February 11, 2024 20:07
@@ -16,14 +16,11 @@
"ci:unit": "jest --ci --coverage"
},
"dependencies": {
"@emotion/react": "^11.11.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good riddance

MikeShi42
MikeShi42 previously approved these changes Feb 24, 2024
@kodiakhq kodiakhq bot merged commit c09342f into main Feb 25, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the sr/mantine-7 branch February 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants