Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use nuqs for ChartPage url query params #311

Merged
merged 1 commit into from
Feb 17, 2024
Merged

fix: Use nuqs for ChartPage url query params #311

merged 1 commit into from
Feb 17, 2024

Conversation

svc-shorpo
Copy link
Contributor

@svc-shorpo svc-shorpo commented Feb 16, 2024 •
edited
Loading

If you type in the chart explorer too fast, your text will get deleted because the url param state gets updated back too slowly.

  • Use nuqs to manage ChartPage url state
  • Add backward compatibility so previous URLs are not broken

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: de2e2b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Minor
@hyperdx/api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-shorpo svc-shorpo merged commit 396468c into main Feb 17, 2024
4 checks passed
@svc-shorpo svc-shorpo deleted the sr/urlparams branch February 17, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeShi42 MikeShi42 MikeShi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svc-shorpo @MikeShi42