Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete team member + invitation #367

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

wrn14897
Copy link
Contributor

@wrn14897 wrn14897 commented Apr 8, 2024

No description provided.

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: 6138758

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@colehpage colehpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So functionality here works as expected, have no issues there aside from a few questions above, and 1 minor aesthetic nit. One question I have is around the intended functionality itself. We have no groups/levels of course here, so unless I'm missing something with current functionality the deletes are open to all. IE I can invite someone to my team, and they can IMMEDIATELY delete ME as a user. This feels....not ideal. Thoughts?

packages/api/src/controllers/user.ts Show resolved Hide resolved
packages/api/src/routers/api/team.ts Show resolved Hide resolved
>
<Modal.Body className="bg-grey rounded">
<h3 className="text-muted">Delete Team Member</h3>
<h5 className="text-muted">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally make this either a <p> or a <div> or whatever our version is instead of <h5> so it looks like
image
and not
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya know, the lowest of the low hanging fruit and all 💪

@wrn14897
Copy link
Contributor Author

So functionality here works as expected, have no issues there aside from a few questions above, and 1 minor aesthetic nit. One question I have is around the intended functionality itself. We have no groups/levels of course here, so unless I'm missing something with current functionality the deletes are open to all. IE I can invite someone to my team, and they can IMMEDIATELY delete ME as a user. This feels....not ideal. Thoughts?

Yeah that's a expected behavior since everyone in the team has the same access level

@kodiakhq kodiakhq bot merged commit f6bdd5e into main Apr 10, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the warren/delete-team-member-n-invitation branch April 10, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants