-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete team member + invitation #367
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So functionality here works as expected, have no issues there aside from a few questions above, and 1 minor aesthetic nit. One question I have is around the intended functionality itself. We have no groups/levels of course here, so unless I'm missing something with current functionality the deletes are open to all. IE I can invite someone to my team, and they can IMMEDIATELY delete ME as a user. This feels....not ideal. Thoughts?
packages/app/src/TeamPage.tsx
Outdated
> | ||
<Modal.Body className="bg-grey rounded"> | ||
<h3 className="text-muted">Delete Team Member</h3> | ||
<h5 className="text-muted"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya know, the lowest of the low hanging fruit and all 💪
Yeah that's a expected behavior since everyone in the team has the same access level |
No description provided.