Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: control logs telemetry using HYPERDX_LOG_LEVEL #78

Merged

Conversation

wrn14897
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: 88a57d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks like vector's CDN is breaking our CI though

@wrn14897
Copy link
Contributor Author

lgtm, looks like vector's CDN is breaking our CI though

Noticed this. Hopefully it gets fixed soon.

@wrn14897 wrn14897 merged commit 8591aee into main Oct 31, 2023
2 of 3 checks passed
@wrn14897 wrn14897 deleted the warren/suppress-otel-collector-n-hostmetrics-logs-telemetry branch October 31, 2023 22:37
@Seikilos
Copy link

Seikilos commented Nov 1, 2023

@MikeShi42 what is exactly breaking for you? I had issues to build the image on our company network due to blacklisted domains.

@wrn14897
Copy link
Contributor Author

wrn14897 commented Nov 1, 2023

@MikeShi42 what is exactly breaking for you? I had issues to build the image on our company network due to blacklisted domains.

It's the vector installation script used in github action CI. I think it's not related. Have the issues with the blacklisted domains been resolved ?

@Seikilos
Copy link

Seikilos commented Nov 1, 2023

@MikeShi42 what is exactly breaking for you? I had issues to build the image on our company network due to blacklisted domains.

It's the vector installation script used in github action CI. I think it's not related. Have the issues with the blacklisted domains been resolved ?

Had to rebuilt the custom image at home and push it to githubs artifact repo, from where I could download it 😐. Can't even access github codespaces from work.
So far I have a working on prem hyperdx and will start sending data when I figured out how to instrument our source properly :)

I am very curious to feed it some real world data!

@MikeShi42
Copy link
Contributor

@Seikilos any chance you'd be open to opening an issue about the blocked domains? Wonder if it's a recurring issue we can at least keep an eye on (and collect more feedback about) if we can't fix in the near term.

@Seikilos
Copy link

Seikilos commented Nov 2, 2023

@Seikilos any chance you'd be open to opening an issue about the blocked domains? Wonder if it's a recurring issue we can at least keep an eye on (and collect more feedback about) if we can't fix in the near term.

Our proxy on our company network started to block all access to CDNs and every url not whitelisted. I am not sure, whether you actually want to track that. We can get a CDN url whitelisted but only for fully qualified urls without wildcards. While I sort of understand the security intention behind it, it makes developing software "less" than ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants