Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added return value of function go. #1607

Merged
merged 5 commits into from
Apr 22, 2020
Merged

Conversation

limingxinleo
Copy link
Member

No description provided.

@limingxinleo
Copy link
Member Author

要不合并到 2.0 里吧,这个一定概率导致 BC 吧。。

虽说,应该不会有人这么用。

比如

function test(string $value = null){
// ...
}

test(go(function(){
// ....
}));

@huangzhhui
Copy link
Member

这个应该不算 BC,因为原来是 void,而且 function 也不存在 override 的场景,所以不会出现父子定义冲突的问题

@Reasno
Copy link
Member

Reasno commented Apr 21, 2020

群里说的通过DI替换Coroutine实现不考虑么

@limingxinleo
Copy link
Member Author

utils不能依赖di的。。。如果有需要,可以直接在skeleton里实现。或者我们di里也加一个Coroutine的实现。然后utils那里根据Container是否存在来切换实现。

@Reasno
Copy link
Member

Reasno commented Apr 21, 2020

utils不能依赖di的。。。如果有需要,可以直接在skeleton里实现。或者我们di里也加一个Coroutine的实现。然后utils那里根据Container是否存在来切换实现。

Skeleton里重写一定会优先于utils里吗 如果是就不麻烦了

@limingxinleo
Copy link
Member Author

并不是,得自己require,如果用psr加载的话,我试过不行。。。

1 similar comment
@limingxinleo
Copy link
Member Author

并不是,得自己require,如果用psr加载的话,我试过不行。。。

@Reasno
Copy link
Member

Reasno commented Apr 21, 2020

并不是,得自己require,如果用psr加载的话,我试过不行。。。

我忘了可以直接在bin/hyperf.php里require了 那也OK了。

@limingxinleo limingxinleo merged commit 0e287e7 into hyperf:master Apr 22, 2020
@limingxinleo limingxinleo deleted the 1.1-go branch April 22, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants