Upgrade doctrine/inflector to ^2.0.
#2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhhui
reviewed
Jul 12, 2020
src/utils/src/Pluralizer.php
Outdated
| /** | ||
| * Get the inflector instance. | ||
| * | ||
| * @return Inflector |
huangzhhui
reviewed
Jul 12, 2020
src/utils/src/Pluralizer.php
Outdated
| * | ||
| * @return Inflector | ||
| */ | ||
| public static function inflector() |
There was a problem hiding this comment.
用 getInflector() 是不是语义更清晰一些呢？
huangzhhui
reviewed
Jul 12, 2020
src/utils/src/Pluralizer.php
Outdated
| /** | ||
| * @var null|Inflector | ||
| */ | ||
| public static $inflector; |
There was a problem hiding this comment.
如果 getInflector 设置了强类型返回，那这里的 public 就应该使用 protected 了，并提供 setInflector() 的方法约束参数类型
|
好的，我今天改一下 |
|
[This message is created by hyperf-bot] [APPROVAL NOTIFIER] This pull-request is APPROVED This pull-request has been approved by: huangzhhui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.