-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babashka test runner #71
Conversation
I skipped some test namespaces due to the incompatibility with missionary:
|
I'm sorry that I made some unnecessary whitespace changes as a result of activating the formatter in my editor. I can revert those if you want. |
@dustingetz I released a new version of babashka and used that in the tests. PR should be good to go from my side. |
Locally, I've used a version of RCF and babashka with this pull applied. Any blockers to getting it merged? |
…time and in clj the test evaluates does not emit any assertions
I attempted to merge today, there is a conflict with this commit: 2d1ef6f @borkdude can you quickly spot the issue? I will take a closer look later, gtg I f'ed up the PR, sorry, i guess i force pushed the wrong thing. Master currently has babashka support merged and pushed, but fails CI in babashka due to the conflict, which is a correct error (I bisected) |
|
Don't worry, I'll take a look :) |
Confirmed electric test suite passes with the babashka support applied, so this is all clear as soon as we fix the conflict. I took a closer look at the conflict and it is nontrivial. |
@dustingetz Fixed in #79 |
thank you! |
:chefskiss:
On July 20, 2023, GitHub ***@***.***> wrote:
thank you!
—
Reply to this email directly, view it on GitHub
<#71 (comment)>, or
unsubscribe <https://github.com/notifications/unsubscribe-
auth/AADOXTA2R4AZIXHGJ5V6P7TXRFZEHANCNFSM6AAAAAASSJLNJA>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
The test runner is currently using a dev version of babashka which implements some previous special-forms as macros.