Skip to content
This repository has been archived by the owner on Feb 8, 2021. It is now read-only.

container stop may interrupt ongoing std streams #604

Closed
gnawux opened this issue Apr 10, 2017 · 0 comments · Fixed by #605
Closed

container stop may interrupt ongoing std streams #604

gnawux opened this issue Apr 10, 2017 · 0 comments · Fixed by #605
Assignees
@gnawux
Labels
class:bug status:patch available
Milestone
v0.8.1

Comments

@gnawux
Copy link
Member

gnawux commented Apr 10, 2017

Illustrated as the following figure, the container stop event will lead to streamconfig.CloseStreams(), which will close stdin pipe, and then lead to tty.Close()

img_4285

This issue was found during process #586 and has not fixed yet.
@feiskyer feiskyer mentioned this issue Apr 10, 2017
Merged
feiskyer added a commit to feiskyer/frakti that referenced this issue Apr 10, 2017
@feiskyer
Bypass stderr checking because of hyperhq/hyperd#604
0952feb
gnawux added a commit to gnawux/hyper that referenced this issue Apr 10, 2017
@gnawux
do not close all streams right after container stopped
7bebc85 
fix hyperhq#604

The container stopping should hup all streams if there are any.
Just check and reclaim any remains after a period should be safe.

Need update hyperhq#585 later if this is approved

Signed-off-by: Wang Xu <gnawux@gmail.com>
@gnawux gnawux mentioned this issue Apr 10, 2017
Merged
@gnawux gnawux self-assigned this Apr 10, 2017
@gnawux gnawux added this to the v0.8.1 milestone Apr 10, 2017
@feiskyer feiskyer mentioned this issue Apr 13, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gnawux gnawux

Labels
class:bug status:patch available
Projects
None yet
Milestone
v0.8.1
Development

Successfully merging a pull request may close this issue.

Do not close all streams right after container stopped gnawux/hyper
1 participant
@gnawux