Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace futures-util with atomic-waker and manual poll_fn #721

Merged
merged 4 commits into from
May 17, 2024

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Oct 28, 2023

This removes ones of the heavier dependencies. The goal is to also remove
futures-util from the rest of the dependency tree, which is hard to justify when
futures-util is used in more fundamental dependencies.

Closes #507

Signed-off-by: John Nunley dev@notgull.net

notgull and others added 2 commits October 28, 2023 13:50
This removes ones of the heavier dependencies. The goal is to also remove
futures-util from the rest of the dependency tree, which is hard to justify when
futures-util is used in more fundamental dependencies.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Contributor Author

notgull commented Nov 15, 2023

@seanmonstar Any chance you can review this?

@seanmonstar
Copy link
Member

Sorry, yes I will take a look, but I want to check out this separate dependency, and just didn't have time while trying to cram all the prep work to release hyper 1.0 (today).

@notgull
Copy link
Contributor Author

notgull commented Dec 30, 2023

@seanmonstar Has hyper v1.0 craziness cooled off enough for you to have time to review this?

@notgull
Copy link
Contributor Author

notgull commented Apr 19, 2024

@seanmonstar Just following up on this. Have you had to chance to consider this yet?

@seanmonstar seanmonstar merged commit 3c41151 into hyperium:master May 17, 2024
6 checks passed
@notgull notgull deleted the fl branch May 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove futures-util dependency
6 participants