Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl HttpTryFrom<Parts> for Uri #95

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Impl HttpTryFrom<Parts> for Uri #95

merged 1 commit into from
Aug 4, 2017

Conversation

carllerche
Copy link
Collaborator

This allows Parts to be used with the builder fns.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile, so can't see very easily: is it possible to construct a Parts that isn't a valid Uri? Like if you set authority and path, but no scheme?

This impl looks fine.

@carllerche
Copy link
Collaborator Author

There currently is an Into implementation, so if there is it would be incorrect...

That said, it might be possible, so that should be audited. I will open an issue to check.

@carllerche
Copy link
Collaborator Author

I created #96 to revisit the Into implementation. If there are error cases, they should be reflected in the HttpTryInto impl as part of resolving #96.

@carllerche carllerche merged commit 0d7fd99 into master Aug 4, 2017
@carllerche carllerche deleted the uri-try-from-parts branch September 7, 2017 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants