Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error if multiple brackets exist in the authority #445

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Return error if multiple brackets exist in the authority #445

merged 2 commits into from
Dec 8, 2020

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Nov 22, 2020

Fixes #435

seanmonstar
seanmonstar reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, it'd be good to add the unit tests the value that was triggering the panic.

@aeryz
Copy link
Contributor Author

aeryz commented Dec 8, 2020

I added a test which tests the exact string that causes the bug.

seanmonstar
seanmonstar approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar merged commit 43c6e84 into hyperium:master Dec 8, 2020
@aeryz aeryz deleted the fix-authority-parse branch December 9, 2020 11:41
@algesten
Copy link

algesten commented Dec 9, 2020

Thanks!

@dekellum dekellum mentioned this pull request Dec 14, 2020
Merged
BenxiangGe pushed a commit to BenxiangGe/http that referenced this pull request Jul 26, 2021
@aeryz
Return error if multiple brackets exist in the authority (hyperium#445)
2a30648 
Closes hyperium#435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected panic for malformed URI with brackets
3 participants
@aeryz @algesten @seanmonstar