Add owned variants for each error #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
reviewed
Jul 28, 2017
|
I'm fine either way, @withoutboats or @seanmonstar, thoughts on naming here? |
|
I don't really love the There is also the pattern from std,
|
For all fallible functions that consume `Bytes` a new `InvalidFooShared` error has been added. Eventually this extra error type can retain the input `Bytes` payload to be re-acquired on error if necessary. Closes #48
|
Sure yeah a suffix of |
|
Ok I'm gonna merge for now, but we can of course tweak before release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all fallible functions that consume
Bytesa newInvalidFooSharederrorhas been added. Eventually this extra error type can retain the input
Bytespayload to be re-acquired on error if necessary.
Closes #48