-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expect: 100-continue not implemented for HTTP/2 #2743
Comments
I'm not sure about the "bug" label, but given the emphasis on correct by Hyper, and this is technically breaking spec I chose "bug" over "feature request". Feel free to change if there is some better convention. |
Yep, sounds like a good thing to add! |
I started looking into it myself, by adding |
Required for [hyper #2743](hyperium/hyper#2743). Expect-continue is mandated as MUST by https://datatracker.ietf.org/doc/html/rfc7231#section-5.1.1
Required for [hyper #2743](hyperium/hyper#2743). Expect-continue is mandated as MUST by https://datatracker.ietf.org/doc/html/rfc7231#section-5.1.1
Support for `Expect: 100-continue` is mandated as MUST by https://datatracker.ietf.org/doc/html/rfc7231#section-5.1.1. Yet servers built on `h2` cannot currently support this requirement. One example of such usage, is [hyper #2743](hyperium/hyper#2743). This approach adds a `send_continue` method to `SendResponse` that a server application can use to implement support itself. This PR does _not_ solve the feature itself, it merely provides sufficient support for a server application to implement the functionality as desired.
Support for `Expect: 100-continue` is mandated as MUST by https://datatracker.ietf.org/doc/html/rfc7231#section-5.1.1. Yet servers built on `h2` cannot currently support this requirement. One example of such usage, is [hyper #2743](hyperium/hyper#2743). This approach adds a `send_continue` method to `SendResponse` that a server application can use to implement support itself. This PR does _not_ solve the feature itself, it merely provides sufficient support for a server application to implement the functionality as desired.
Support for `Expect: 100-continue` is mandated as MUST by https://datatracker.ietf.org/doc/html/rfc7231#section-5.1.1. Yet servers built on `h2` cannot currently support this requirement. One example of such usage, is [hyper #2743](hyperium/hyper#2743). This approach adds a `send_info` method to `SendResponse` that a server application can use to implement support itself. This PR does _not_ solve the feature itself, it merely provides sufficient support for a server application to implement the functionality as desired.
Support for `Expect: 100-continue` is mandated as MUST by https://datatracker.ietf.org/doc/html/rfc7231#section-5.1.1. Yet servers built on `h2` cannot currently support this requirement. One example of such usage, is [hyper #2743](hyperium/hyper#2743). This approach adds a `send_info` method to `SendResponse` that a server application can use to implement support itself. This PR does _not_ solve the feature itself, it merely provides sufficient support for a server application to implement the functionality as desired.
Hyper (server) does not support sending
100 Continue
upon receiving an HTTP/2 request with aExpect: 100-continue
specified. This is currently blocking moving a project from HTTP/1.1 to HTTP2 for me.I've been digging through the specs, and as far as I can tell;
I think the simple solution here is to try to replicate the behavior hyper already expose for HTTP/1.1? #838
The text was updated successfully, but these errors were encountered: