Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review cargo-deny configuration #146

Closed
alce opened this issue Nov 21, 2019 · 1 comment
Closed

Review cargo-deny configuration #146

alce opened this issue Nov 21, 2019 · 1 comment

Comments

@alce
Copy link
Collaborator

alce commented Nov 21, 2019

I recently had to wrestle cargo-deny for a PR to pass CI. In the process, it helped getting rid of duplicate rand versions, which is not an essential dependency for Tonic.

On the other hand, I had to allow multiple versions of crossbeam-queue to exist in the dependency tree. I think this is ok for now but we may want to revisit deny.toml once we upgrade tokio, futures and other essential dependencies.

cc #93

@Jake-Shadle
Copy link
Contributor

Note that cargo deny will show warnings if you've specified to skip a particular crate + version that isn't found in the dependency graph so that you can clean up configs as your dependency graph changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants