Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce dependencies #93

Closed
LucioFranco opened this issue Oct 23, 2019 · 2 comments
Closed

Reduce dependencies #93

LucioFranco opened this issue Oct 23, 2019 · 2 comments
Labels
A-build A-tonic E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.
Milestone
0.1

Comments

@LucioFranco
Copy link
Member

We should attempt to use feature flags to reduce dependencies that we don't use.
@LucioFranco LucioFranco added E-help-wanted Call for participation: Help is requested to fix this issue. E-easy Call for participation: Experience needed to fix: Easy / not much A-tonic A-build labels Oct 23, 2019
@blittable blittable mentioned this issue Oct 27, 2019
Closed
@blittable
Copy link
Contributor

Quick question here - feature flags to narrow the import scope of the upstream dependencies or features flags in the tonic code (e.g. put cfg attributes on handful of trace crate usages?)

I looked at the upstream dependencies, but didn't see any good opportunities to factor out features.

@LucioFranco
Copy link
Member Author

@blittable as of right now there are not many but that is because we pull in the whole world with the transport feature. I think we can revisit this issue once tokio/hyper get a stable release.

@alce alce mentioned this issue Nov 21, 2019
Closed
@LucioFranco LucioFranco added this to the 0.1 milestone Dec 6, 2019
@LucioFranco LucioFranco mentioned this issue Jan 11, 2020
Merged
brentalanmiller pushed a commit to brentalanmiller/tonic that referenced this issue Oct 6, 2023
@djc
Fix warning about renamed lint (hyperium#93)
ce11bf7
brentalanmiller pushed a commit to brentalanmiller/tonic that referenced this issue Oct 6, 2023
@Noah-Kennedy
chore: prepare tokio-native-tls 0.3.1 (hyperium#129)
3716340 
# 0.3.1 (February 4th, 2023)

### Additions
- Add Vendored Feature ([hyperium#125])
- Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream\<S\> ([hyperium#74])

### Internal
- Fix warning about renamed lint ([hyperium#93])
- fix a handful of lints, one of which was breaking the build ([hyperium#65])

[hyperium#65]: tokio-rs/tls#65
[hyperium#74]: tokio-rs/tls#74
[hyperium#93]: tokio-rs/tls#93
[hyperium#125]: tokio-rs/tls#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build A-tonic E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@LucioFranco @blittable