Remove warp examples #1708
Merged
Remove warp examples #1708
+1
−412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warp is much less popular than Axum today - 30,000 downloads/day on crates.io vs Axum's 200,000/day, as a rough quantiative measure. As well, warp does not yet have compatiblity with hyper-1.0, though there is some work ongoing (seanmonstar/warp#1088). When warp adds compatibility with hyper 1.0, these examples can be restored.
17 tasks
tisonkun
approved these changes
May 26, 2024
There was a problem hiding this comment.
Thanks for helping drive this progress.
I'm waiting for the final blocker at tonic to bump all our HTTP stack to hyper-1.0 ... It's now blocked by we defining middleware for both tonic-web and axum so we cannot bump axum along and let tonic use the 0.6 version.
|
@tisonkun we all want it, no need to keep piling on. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warp is much less popular than Axum today - 30,000 downloads/day on crates.io vs Axum's 200,000/day, as a rough quantiative measure.
As well, warp does not yet have compatiblity with hyper-1.0, though there is some work ongoing (seanmonstar/warp#1088).
When warp adds compatibility with hyper 1.0, these examples can be restored.