Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Switch to use GitHub Action for cargo-deny #201

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

repi
Copy link
Contributor

@repi repi commented Dec 20, 2019

This upgrades CI from manually downloading cargo-deny to use our new cargo-deny GitHub Action.

Includes a lot of fixes, upgrades a new features as it brings cargo-deny from 0.4.0 to 0.5.2. List of changes:
https://github.com/EmbarkStudios/cargo-deny/releases

Biggest one here is that it will now also check the RUSTSEC security advisory database and will (by default) fail builds if any security advisories are detected for used crates

I was thinking first that we should wait until we have a v1 of the action and cargo-deny before using it, but as tonic is one of the first non-Embark repos using cargo-deny I think we can switch to the action here - but monitor how it works. Can always pin the action to an exact version also and/or disable advisories or other features.

cc @Jake-Shadle @LucioFranco

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Happy to try it out! Thanks!

@repi
Copy link
Contributor Author

repi commented Dec 20, 2019

Great!

And this passed quickly, only one advisory warning, but no failures.

warning[RUSTSEC-2019-0031]: spin is no longer actively maintained

     ┌── /github/workspace/Cargo.lock:149:1 ───
     │
 149 │ spin 0.5.2 registry+https://github.com/rust-lang/crates.io-index
     │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unmaintained advisory detected
     │
     = The author of the `spin` crate does not have time or interest to maintain it.
       
       Consider [`lock_api`](https://crates.io/crates/lock_api) (a subproject of
       `parking_lot`) as an alternative which also supports `no_std` environments.
     = URL: https://github.com/mvdnes/spin-rs/commit/7516c80
     = spin v0.5.2
       ├── lazy_static v1.4.0
       │   ├── bstr v0.2.8
       │   │   └── csv v1.1.1
       │   │       └── criterion v0.3.0

@LucioFranco
Copy link
Member

@repi yeah, looks like a criterion dep so not a big deal, well prob move off that soon.

@LucioFranco LucioFranco changed the title Switch to use GitHub Action for cargo-deny chore(ci): Switch to use GitHub Action for cargo-deny Dec 20, 2019
@LucioFranco LucioFranco merged commit 5e6b1fe into hyperium:master Dec 20, 2019
@repi repi deleted the cargo-deny-action branch December 20, 2019 16:41
rabbitinspace pushed a commit to satelit-project/tonic that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants